Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bigquery): get literals working again #8577

Merged
merged 3 commits into from
Mar 12, 2024
Merged

fix(bigquery): get literals working again #8577

merged 3 commits into from
Mar 12, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Mar 7, 2024

@cpcloud cpcloud added this to the 9.0 milestone Mar 7, 2024
@cpcloud cpcloud added bigquery The BigQuery backend ci-run-cloud Run BigQuery, Snowflake, Databricks, and Athena backend tests labels Mar 7, 2024
@cpcloud cpcloud requested review from gforsyth and tswast March 7, 2024 14:44
@ibis-docs-bot ibis-docs-bot bot removed the ci-run-cloud Run BigQuery, Snowflake, Databricks, and Athena backend tests label Mar 7, 2024
@cpcloud cpcloud force-pushed the fix-bigquery-literals branch from eb28cab to fc7bc23 Compare March 12, 2024 10:22
@cpcloud cpcloud marked this pull request as draft March 12, 2024 10:22
@cpcloud cpcloud force-pushed the fix-bigquery-literals branch from fc7bc23 to 95aee71 Compare March 12, 2024 10:47
@cpcloud cpcloud added the ci-run-cloud Run BigQuery, Snowflake, Databricks, and Athena backend tests label Mar 12, 2024
@ibis-docs-bot ibis-docs-bot bot removed the ci-run-cloud Run BigQuery, Snowflake, Databricks, and Athena backend tests label Mar 12, 2024
@cpcloud cpcloud force-pushed the fix-bigquery-literals branch from 95aee71 to 44919ef Compare March 12, 2024 16:33
@cpcloud cpcloud added the ci-run-cloud Run BigQuery, Snowflake, Databricks, and Athena backend tests label Mar 12, 2024
@cpcloud cpcloud marked this pull request as ready for review March 12, 2024 16:35
@ibis-docs-bot ibis-docs-bot bot removed the ci-run-cloud Run BigQuery, Snowflake, Databricks, and Athena backend tests label Mar 12, 2024
@cpcloud
Copy link
Member Author

cpcloud commented Mar 12, 2024

This PR should fix the failing BigQuery jobs on main.

@cpcloud cpcloud force-pushed the fix-bigquery-literals branch from 44919ef to 87160ac Compare March 12, 2024 18:59
@cpcloud
Copy link
Member Author

cpcloud commented Mar 12, 2024

Apparently I hadn't squashed all the caches.

@cpcloud cpcloud added ci-run-cloud Run BigQuery, Snowflake, Databricks, and Athena backend tests tests Issues or PRs related to tests ci Continuous Integration issues or PRs labels Mar 12, 2024
@ibis-docs-bot ibis-docs-bot bot removed the ci-run-cloud Run BigQuery, Snowflake, Databricks, and Athena backend tests label Mar 12, 2024
@cpcloud cpcloud merged commit 6369734 into ibis-project:main Mar 12, 2024
87 checks passed
@cpcloud cpcloud deleted the fix-bigquery-literals branch March 12, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gforsyth gforsyth gforsyth approved these changes

@tswast tswast Awaiting requested review from tswast

Assignees
No one assigned
Labels
bigquery The BigQuery backend ci Continuous Integration issues or PRs tests Issues or PRs related to tests
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @gforsyth