perf(sql): don't compile pretty sql by default #8616
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been compiling pretty formatted SQL queries so far. While this was handy, pretty formatting doesn't give any value when directly passed to a backend, it mostly matters when presented to users.
Compiling a big query like the one provided in #8484 takes
3.83s
withpretty=True
while it takes almost half the time2.17s
withpretty=False
.