fix(oracle): map bare NUMBER to int64 and consolidate data type mapping code for shared inference
#8626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
changed the title
cpcloud
changed the title
NUMBER to int64 and consolidate data type mapping code for shared inference
…apping code for shared inference
cpcloud
force-pushed
the
fix-oracle-type-inference
branch
from
978fdb6 to
5001a74
Compare
cpcloud
force-pushed
the
fix-oracle-type-inference
branch
from
5001a74 to
dcab164
Compare
gforsyth
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug discovered during polars dot sql implementation where we were mapping empty precision and scale decimal types, but the oracle docs say that empty precision and scale together are mapped to number(38, 0).
The discovery during polars dot sql implementation is incidental, due to the test I changed, which is included here.