Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(backends): remove _metadata method in favor of _get_schema_using_query #8627

Merged

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Mar 12, 2024

Remove the unnecessary _metadata method in favor of _get_schema_using_query

@cpcloud cpcloud added this to the 9.0 milestone Mar 12, 2024
@cpcloud cpcloud added refactor Issues or PRs related to refactoring the codebase backends Issues related to all backends labels Mar 12, 2024
Copy link
Contributor

ACTION NEEDED

Ibis follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message.

Please update your PR title and description to match the specification.

@cpcloud cpcloud force-pushed the cleanup-schema-from-query-inference branch from c810bbf to 9461153 Compare March 12, 2024 13:18
@cpcloud cpcloud changed the title cleanup schema from query inference refactor(backends): remove _metadata method in favor of _get_schema_using_query Mar 12, 2024
@cpcloud cpcloud requested a review from kszucs March 12, 2024 13:20
@cpcloud cpcloud force-pushed the cleanup-schema-from-query-inference branch from 9461153 to 733ec36 Compare March 12, 2024 13:38
Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thanks for working on this!

@cpcloud cpcloud force-pushed the cleanup-schema-from-query-inference branch 2 times, most recently from aa2291a to ff936e6 Compare March 12, 2024 14:02
@cpcloud cpcloud added the ci-run-cloud Run BigQuery, Snowflake, Databricks, and Athena backend tests label Mar 12, 2024
@ibis-docs-bot ibis-docs-bot bot removed ci-run-cloud Run BigQuery, Snowflake, Databricks, and Athena backend tests labels Mar 12, 2024
@cpcloud cpcloud force-pushed the cleanup-schema-from-query-inference branch from ff936e6 to d6e00a8 Compare March 12, 2024 20:13
@cpcloud cpcloud added the ci-run-cloud Run BigQuery, Snowflake, Databricks, and Athena backend tests label Mar 12, 2024
@ibis-docs-bot ibis-docs-bot bot removed the ci-run-cloud Run BigQuery, Snowflake, Databricks, and Athena backend tests label Mar 12, 2024
@cpcloud cpcloud merged commit 4ec7daf into ibis-project:main Mar 12, 2024
83 checks passed
@cpcloud cpcloud deleted the cleanup-schema-from-query-inference branch March 12, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backends Issues related to all backends refactor Issues or PRs related to refactoring the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants