feat(mssql): use integrated auth when no user or password supplied #8668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcrist
approved these changes
Mar 15, 2024
The method for enabling Integrated Authentication with ODBC is to not provide a `user` or `password`, and to set `Trusted_Connection = 'true'`. If `Trusted_Connection` is already set in `kwargs`, do nothing, because either the user set it to 'true' and it will work untouched, or they're specifying 'false' for a reason and we should leave it alone.
Added a tabset to show the different probable driver strings required for using ODBC vs unixODBC. Documented the new defaults for integrated authentication.
Co-authored-by: Jim Crist-Harif <jcristharif@gmail.com>
cpcloud
force-pushed
the
mssql_integrated_auth
branch
from
0a90107 to
6f697a9
Compare
cpcloud
approved these changes
Mar 17, 2024
cpcloud
added
docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method for enabling Integrated Authentication with ODBC is to not
provide a
userorpassword, and to setTrusted_Connection = 'true'.If
Trusted_Connectionis already set inkwargs, do nothing, becauseeither the user set it to 'true' and it will work untouched, or they're
specifying 'false' for a reason and we should leave it alone.- feat(mssql): use integrated auth when no user or password supplied
Resolves #8657