refactor(cleanup): remove deprecated methods and properties #8701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`op` as a method on another operation was deprecated in 4.0. `output_dtype` and `output_shape` were deprecated in 7.0. I think 2 major versions is a reasonable deprecation cycle.
jcrist
approved these changes
Mar 19, 2024
|
I am feeling nostalgic :) |
cpcloud
added
the
breaking change
cpcloud
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opas a method on another operation was deprecated in 4.0.output_dtypeandoutput_shapewere deprecated in 7.0.I think 2 major versions is a reasonable deprecation cycle.
BREAKING CHANGE: Deprecated methods and properties
op,output_dtype, andoutput_shapeare removed.opis no longer needed, and use.dtypeand.shaperespectively for the other two.