Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): remove the remnants of now unsupported timecontext feature #8721

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

kszucs
Copy link
Member

@kszucs kszucs commented Mar 21, 2024

The timecontext feature was only supported by the pandas, dask and pyspark backends.
Since the epic split refactor none of the ported backends support this feature.

BREAKING CHANGE: timecontext feature is removed

@kszucs kszucs changed the title refactor: remove the remnants of now unsupported timecontext feature refactor(api): remove the remnants of now unsupported timecontext feature Mar 21, 2024
@kszucs kszucs changed the title refactor(api): remove the remnants of now unsupported timecontext feature refactor(api): remove the remnants of now unsupported timecontext feature Mar 21, 2024
@cpcloud cpcloud added this to the 9.0 milestone Mar 21, 2024
@cpcloud cpcloud added breaking change Changes that introduce an API break at any level pandas The pandas backend pyspark The Apache PySpark backend dask The Dask backend labels Mar 21, 2024
@cpcloud
Copy link
Member

cpcloud commented Mar 21, 2024

Looks like I broke the flink tests. Looking into it now.

Feel free to merge this in the meantime.

The timecontext feature was only supported by the pandas, dask and pyspark backends.
Since the epic split refactor none of the ported backends support this feature.

BREAKING CHANGE: timecontext feature is removed
@kszucs
Copy link
Member Author

kszucs commented Mar 21, 2024

Everything looks good now, thanks! Merging.

@kszucs kszucs merged commit 0a00a05 into ibis-project:main Mar 21, 2024
91 checks passed
@kszucs kszucs deleted the timectx branch March 21, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Changes that introduce an API break at any level dask The Dask backend pandas The pandas backend pyspark The Apache PySpark backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants