-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(blog): portable dataflows with Ibis and Hamilton #8798
Conversation
ACTION NEEDED Ibis follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
thanks! I think this will fail the docs PR check, as |
@lostmygithubaccount It's passing because the code blocks aren't executed. |
ah missed that -- will review soon! @zilto you may want to have the code blocks actually execute (and then my comment above would apply) other offhand comment before a proper review would be wrapping the lines to ~90 characters -- see https://ibis-project.org/contribute/03_style#text-formatting |
aaah, that makes a lot sense. I was scratching my head at why no Will make the changes |
I updated the Now, my code examples depend on a parquet dataset that is 23KB. I didn't commit it since |
@zilto apologies for the slow response here!
I think this is small enough that just adding it is fine. alternatives would be:
neither really seem worth it in this case, and 2) would mean changing a lot of the code |
@zilto -- if you add the parquet file here (or you can send it over Zulip to me -- at least I think that's possible) I can stick it in one of our buckets and give you a public http link to pull from. |
it is trying to run the Python code (and not finding the hamilton import), suggesting the execution freeze doesn't exactly match after you made some changes. can you try re-executing and ensuring it's up to date? |
Ok, odd bug... I just updated the files |
278d431
to
1dcada6
Compare
Description of changes
Ported a blog post from the Hamilton Substack to the Quarto format for cross-posting on the Ibis blog. This was discussed with @lostmygithubaccount on Zulip.
First time using Quarto. I managed to successfully build
.qmd
files and preview the post. Everything seemed fine. However, I see other blogs have files under_freeze/posts/
, but I couldn't find how to generate them.