refactor(formats): remove unnecessary schema argument from schema inference #8814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ask()` Dask is not an explicitly supported format and these methods were just aliases for `.to_pandas()` and `.from_pandas()`. BREAKING CHANGE: Schema.to_dask(), Schema.from_dask(), DataType.from_dask(), DataType.to_dask() methods are removed, use `.to_pandas()` and `.from_pandas()` methods instead
kszucs
force-pushed
the
schema-infer-schema
branch
from
e37d495 to
3ddf520
Compare
kszucs
force-pushed
the
schema-infer-schema
branch
from
3ddf520 to
5d71e85
Compare
cpcloud
approved these changes
Mar 28, 2024
gforsyth
reviewed
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sch.infer()andDataMapper.infer_table()implementations had an unnecessary schema argument which wan't actually used.