fix(snowflake): manually construct quantile calls with WITHIN GROUP
#8846
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Snowflake SQLGlot dialect rewrites calls to
percentile_cont
toinclude WITHIN GROUP (ORDER BY ...)
as per https://docs.snowflake.com/en/sql-reference/functions/percentile_cont
using the rule
add_within_group_for_percentiles
If we have copy=False set in our call to
compile
, if there is morethan one quantile, the rewrite rule fails on the second pass because
of some mutation in the first pass. To avoid this error, we create the
expression with the within group included already and skip the (now
unneeded) rewrite rule.
Fixes #8768