Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(snowflake): create an ibis backend from a snowpark session #8962

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Apr 14, 2024

Add a from_snowpark method to Snowflake backend. cc @IndexSeek.

@cpcloud cpcloud added feature Features or general enhancements snowflake The Snowflake backend labels Apr 14, 2024
@cpcloud cpcloud force-pushed the ibis-from-snowpark branch 3 times, most recently from 4919101 to f50c831 Compare April 14, 2024 13:09
@cpcloud cpcloud added the ci-run-cloud Run BigQuery, Snowflake, Databricks, and Athena backend tests label Apr 14, 2024
@ibis-docs-bot ibis-docs-bot bot removed the ci-run-cloud Run BigQuery, Snowflake, Databricks, and Athena backend tests label Apr 14, 2024
@cpcloud cpcloud force-pushed the ibis-from-snowpark branch from f50c831 to f5a502a Compare April 14, 2024 13:35
@cpcloud
Copy link
Member Author

cpcloud commented Apr 14, 2024

Here's the entire test suite run from an Ibis Snowflake backend initialized from a Snowpark connection:

…/ibis on  ibis-from-snowpark is 📦 v8.0.0 via 🐍 v3.11.8 via ❄️   impure (ibis-3.11.8-env)
❯ pytest -m snowflake -n 8 --dist loadgroup --snapshot-update -q -x
bringing up nodes...
.xx..........................x.........x.........x....x......x...............x........x....x..x.............x......x......x....x..x.x......xxxxxxxxxxxx....x..x........x......xx.x......x.. [ 11%]
.x.....x..x....x.x..x...........x......x.x...x..xxxxxxxx.xx.x.x....x.xxx..x..x..............x..........s................x.......s..........s......................s...................s.... [ 22%]
.........................................................x...x..x........x..x......x...xx.x........x...x..x.......xx...x..........................x.xx.........x......xxx.................. [ 34%]
...x.....x...x...x........................x..................x...................x............................x...................x.........x.....xx.x.......x...x..x..xx..x.....x......... [ 45%]
....x.x....................x......x..x..x..xx..xx..xxxxx......xxx.xxx.x....xxxx.xxx.xxx....xx.xx.xxxxx.xxxxx...xxxxxxxx..xxxx.xxxx.x..x....xx..x..x.................x...................... [ 56%]
.......x..............x......x.xx..................x....x......x..........................x..xx...x..............................................x....xx................................... [ 68%]
x.................................x..x........x........................x..x.x...xxx...x.........x.x.......................x.......x.x......x..............x......x..x....x....xx........... [ 79%]
......x........x.....................x..x..x.........x.x..x....x...............x.......x.s..............x....x..............x....x........x....x.............................s............. [ 90%]
.......................................................................................................................................................                                     [100%]
1408 passed, 7 skipped, 232 xfailed in 145.30s (0:02:25)

@cpcloud cpcloud force-pushed the ibis-from-snowpark branch from edf5bf9 to 41d33f9 Compare April 14, 2024 13:42
@cpcloud cpcloud marked this pull request as ready for review April 14, 2024 13:43
@IndexSeek
Copy link
Member

This is going to be great for interoperability! 🎉

Thank you for working on this, I'm looking forward to giving it a try.

@kszucs kszucs merged commit f15d033 into ibis-project:main Apr 15, 2024
84 checks passed
@cpcloud cpcloud deleted the ibis-from-snowpark branch April 15, 2024 10:10
@cpcloud cpcloud added this to the 9.0 milestone Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features or general enhancements snowflake The Snowflake backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants