Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snowflake): initialize _from_snowpark variable in constructor to ensure it is defined #8970

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Apr 15, 2024

Fixes an issue with the _from_snowpark instance variable being used before it is defined.

@cpcloud cpcloud added this to the 9.0 milestone Apr 15, 2024
@cpcloud cpcloud added bug Incorrect behavior inside of ibis snowflake The Snowflake backend labels Apr 15, 2024
@cpcloud
Copy link
Member Author

cpcloud commented Apr 15, 2024

Snowflake tests are passing:

❯ pytest -m snowflake -n 8 --dist loadgroup --snapshot-update -q -x
bringing up nodes...
.....................x......x.......x......x...................................x......x......s.....x...x...............................s..........................s..................s.... [ 11%]
......................x.....x.xxxxxxxx..x....s.x.................x.x.x..xx....xx...........x...............x..............xx.....x.........x....x.......................x............x.... [ 22%]
...................x........x......x.xx.............x......x.....................xx..................xx.....x...............x......x...........................xx.......x.....x........... [ 33%]
..x..x.x.......xx..x..x........x........xx.......x.....x...xxx............x....x...........x....x.....x....x..x...........x.....x.........xx.x..x.x.......x............x..x.....x..xx...x. [ 45%]
....x...............x...x.........x...x..........s.x..................xxxx.............x..xx.x..xx...xxxxxxxxx.x.xx...xxx.x.xxxx.x.xxxxx.xxx.x....xxx...xx.x.x.xxxxx..xx.x.xx.xxxxx.xxxx.. [ 56%]
...xx.......x..x..........................x.................................................................x...........................x............x......xx.....x...x.................. [ 67%]
............x.........x.x........x..x........x.........x....x............xx.......x....x..........xx.xxxxxxxxxxx........x.x....x........................x.............x...............x... [ 79%]
..............x............xx.x....x...x........x............................x....x......xx..x...x..xx.........x.........x.x...x...x........xs....x...xx.x....x.....x..................... [ 90%]
...............................................................................................................................................................                            [100%]
1408 passed, 7 skipped, 232 xfailed in 162.43s (0:02:42)

@cpcloud
Copy link
Member Author

cpcloud commented Apr 15, 2024

Running with snowpark:

…/ibis-fix-snowflake on  ibis-fix-snowflake is 📦 v8.0.0 via 🐍 v3.11.8 via ❄️   impure (ibis-3.11.8-env) took 14s
❯ SNOWFLAKE_SNOWPARK=1 pytest -m snowflake -n auto --dist loadgroup -x -q
bringing up nodes...
..x...x......x.......xx....xx.......xxx....x..............x..x..x...x.xxx...x.....x.x......x.................x......x........x.xx.x...x..x....x................x......x..xx.....x......... [ 11%]
................x.x..xx.x..xxx.x..x..x.x...x...x..........x.......x.....x.x..x..xx..x.x....................x.....x............x.......................x...................x............... [ 22%]
...x...xx.....x........x.....x..xx....x......................................x.sxx.........x................x...............x...............x...........x.............s................... [ 33%]
xx.x..x.......x...............x..........x..x....x.x...............x.....x......x.......x........x.....x..................................................................x....x..x.x..xxx [ 45%]
...x.x..x.xx.xxx..xx.x.....x....xx.xxxx.xxxxx..x.xx.xxxxxx..x.xxx.xxx.x.xxx.xx.xx....x.xxx..x.xx.x.......xxx..xx..xxx.........x..............x....x.............x.................x....... [ 56%]
...x........x....x......x.............x.....xx..xx...x.....x...............x........x...........x.............x..........................................x................................ [ 67%]
........x.................x...x........x..x..x........xxxxxx.....x.x.......xx.x..x.xx..........x..xx...................s.......x................s............s.........s.................. [ 79%]
.................x.........x...............................x..x..x..x..x......x....x....x..........x...x......x...x..................x........x..xx......x..................x............. [ 90%]
.................s.............................................................................................................................................                            [100%]
1408 passed, 7 skipped, 232 xfailed in 123.54s (0:02:03)

@cpcloud cpcloud merged commit 5722a10 into ibis-project:main Apr 15, 2024
88 checks passed
@cpcloud cpcloud deleted the ibis-fix-snowflake branch April 15, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis snowflake The Snowflake backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant