Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump dependencies' lower bounds to reflect tested minimum version #8977

Merged
merged 11 commits into from
Apr 16, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Apr 16, 2024

Bump the lower bound of pandas to reflect the actual lower bound that we test against in CI. Also bump the upper bound in conda environmentl YAMLs for recent fixes to support pandas 2.2.

Closes #8795.

@cpcloud cpcloud added this to the 9.0 milestone Apr 16, 2024
@cpcloud cpcloud added pandas The pandas backend dependencies Issues or PRs related to dependencies labels Apr 16, 2024
@cpcloud cpcloud changed the title fix(deps): bump pandas lower bound to reflect tested minimum version fix(deps): bump dependencies' lower bounds to reflect tested minimum version Apr 16, 2024
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: assuming CI passes

@gforsyth
Copy link
Member

hrr, apparently ParquetWriter.write_batch was added in pyarrow 7.0

@gforsyth
Copy link
Member

I'm going to rebase and bump pyarrow lower bound to 7

@gforsyth gforsyth force-pushed the bump-pandas-lower-bound branch from 0bfb59f to e0f32f5 Compare April 16, 2024 14:05
@cpcloud
Copy link
Member Author

cpcloud commented Apr 16, 2024

Let's just bump to 10.0.1 (because of this failure).

@gforsyth
Copy link
Member

Aaand pyarrow csv WriteOptions didn't add delimiter until pyarrow 8.0 -- bump to 8?

@cpcloud
Copy link
Member Author

cpcloud commented Apr 16, 2024

The failing clickhouse test looks flaky. I'll put up a separate PR for that.

@cpcloud
Copy link
Member Author

cpcloud commented Apr 16, 2024

Actually, making that test less flaky will probably require the ability to prevent listing temp tables, so let's just rerun the clickhouse tests.

@gforsyth
Copy link
Member

merging

@gforsyth gforsyth merged commit 9c29f28 into ibis-project:main Apr 16, 2024
83 checks passed
@cpcloud cpcloud deleted the bump-pandas-lower-bound branch April 16, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issues or PRs related to dependencies pandas The pandas backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: minimum version of pyarrow is incorrect
2 participants