Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(structs): ensure that isin works with struct membership #8978

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Apr 16, 2024

Fixes #8755.

@cpcloud cpcloud added bug Incorrect behavior inside of ibis sql Backends that generate SQL labels Apr 16, 2024
@cpcloud cpcloud requested a review from kszucs April 16, 2024 11:24
@cpcloud cpcloud added this to the 9.0 milestone Apr 18, 2024
@cpcloud cpcloud enabled auto-merge (squash) April 18, 2024 11:11
@cpcloud cpcloud disabled auto-merge April 18, 2024 11:11
@cpcloud
Copy link
Member Author

cpcloud commented Apr 18, 2024

Clouds are passing the new test:

…/ibis on  in-struct is 📦 v8.0.0 via 🐍 v3.12.2 via ❄️   impure (ibis-3.12.2-env) took 17s
❯ pytest 'ibis/backends/tests/test_struct.py::test_isin_struct' -m 'snowflake or bigquery'
======================================================================================= test session starts ========================================================================================
platform linux -- Python 3.12.2, pytest-8.1.1, pluggy-1.4.0
benchmark: 4.0.0 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
Using --randomly-seed=1473849520
rootdir: /home/cloud/src/ibis
configfile: pyproject.toml
plugins: xdist-3.5.0, pytest_httpserver-1.0.10, cov-5.0.0, timeout-2.3.1, benchmark-4.0.0, randomly-3.15.0, hypothesis-6.100.1, repeat-0.9.3, snapshot-0.9.0, mock-3.14.0, clarity-1.0.1
collected 20 items / 18 deselected / 2 selected

ibis/backends/tests/test_struct.py ..                                                                                                                                                        [100%]

=========================================================================== 2 passed, 18 deselected in 83.82s (0:01:23) ============================================================================

@cpcloud cpcloud enabled auto-merge (squash) April 18, 2024 11:14
@cpcloud cpcloud merged commit c0c508e into ibis-project:main Apr 18, 2024
79 of 82 checks passed
@cpcloud cpcloud deleted the in-struct branch April 18, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis sql Backends that generate SQL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: CTE'd values aren't referenced correctly
2 participants