Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snowflake): set con outside of _setup_session call #8979

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Apr 16, 2024

Fixes the failing Snowflake tests in CI.

@cpcloud cpcloud added bug Incorrect behavior inside of ibis snowflake The Snowflake backend labels Apr 16, 2024
@cpcloud cpcloud requested a review from kszucs April 16, 2024 11:37
@cpcloud
Copy link
Member Author

cpcloud commented Apr 16, 2024

Cloud tests are passing:

…/ibis on  fix-snowpark-con is 📦 v8.0.0 via 🐍 v3.12.2 via ❄️   impure (ibis-3.12.2-env)
❯ pytest -m snowflake -n auto --dist loadgroup --snapshot-update -q -x
bringing up nodes...
.........................xx.................................x..................x....xx.......x......................................x....x..x...x......x.x.x.x...x...............xx.. [ 10%]
..........x........x.....x.............xx.........x.......x....x...x..x...................x.......................x..........x.....x..x......x....x....x..x.x.x.....xx.x.......x....x [ 21%]
...............x........xx.xx...........x.......xx.........x..x............x.....................x.............x.......................xx......x......x......x...........x...x....... [ 32%]
.x....x..x.x........s.x.s.....................x.......x.....................................................x.........x............................................x.......x......... [ 43%]
................xxxxxxxx......x...x..x...x.........x...x.................x.......x.....xx..x.............x.......................x................................x.........xx....x.. [ 54%]
...x.x.x.xxx...xxxxx..xx...x.xx.x.....x.....x...x...x.....x..xx.....x..xx...xxx...xxx..x..x...x...s.x...........x............x.....................xx.............................x.. [ 65%]
............x.x..xx.xxx..x.x.xx.x..xxx..x.x.xxx..x..xxx..xxxxxxxxx..xx............xxxxxx..x..x.xxxxx...xxxx.x....x..xxx.x.x.x.x............x................................s........ [ 76%]
.....................x.................x..x.....x...x...x.........x....x...............x...x....x..x...x...x..x..x........x.xxx....................x...x..x.............sx.x......... [ 87%]
x.......x..x............s............................................................s........................................................................................s...... [ 98%]
....................s............                                                                                                                                                     [100%]
1421 passed, 9 skipped, 232 xfailed in 124.41s (0:02:04)

@cpcloud cpcloud added this to the 9.0 milestone Apr 16, 2024
@cpcloud
Copy link
Member Author

cpcloud commented Apr 16, 2024

Merging to get CI passing again.

@cpcloud cpcloud merged commit 3b1a6ef into ibis-project:main Apr 16, 2024
86 checks passed
@cpcloud cpcloud deleted the fix-snowpark-con branch April 16, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis snowflake The Snowflake backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant