Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove all extra installation from contributing docs #9004

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Apr 18, 2024

We removed the all extra in a previous PR and it is no longer necessary.

Fixes #9002

@cpcloud cpcloud added this to the 9.0 milestone Apr 18, 2024
@cpcloud cpcloud added the docs Documentation related issues or PRs label Apr 18, 2024
@cpcloud
Copy link
Member Author

cpcloud commented Apr 18, 2024

@ncclementi Do you remember if we didn't add black for a specific reason?

@ncclementi
Copy link
Contributor

I believe it was because we to ruff, do we need black?

@cpcloud
Copy link
Member Author

cpcloud commented Apr 18, 2024

Yes, it's still required for the decompiler extra.

ruff is used to format ibis code during development, this use of black is for a feature inside of ibis.

Copy link
Contributor

@ncclementi ncclementi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@cpcloud cpcloud merged commit 03825b6 into ibis-project:main Apr 18, 2024
92 checks passed
@cpcloud cpcloud deleted the fix-reqs-in-contributing branch April 18, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related issues or PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: pytest -m core fails on main due to missing blackpackage
2 participants