fix: make devcontainer work correctly #9019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
cpcloud
approved these changes
Apr 18, 2024
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/env bash | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
I like to think it's more portable even in modern times! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
These change are what was required for me to get the devcontainer to run on my machine. Before these changes, the devcontainer image wasn't building correctly because it was missing gdal. The root cause of that was that the devcontainer.json wasn't using the Dockerfile.
Issues closed
Resolves #9011