Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pyspark): ensure that the output of zip matches the expected ibis schema #9052

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Apr 25, 2024

Fix PySpark zip implementation to ensure that its output matches the schema expected by Ibis. Fixes #9049.

@cpcloud cpcloud added this to the 9.0 milestone Apr 25, 2024
@cpcloud cpcloud added bug Incorrect behavior inside of ibis pyspark The Apache PySpark backend datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) labels Apr 25, 2024
@cpcloud cpcloud force-pushed the array-zip-unnest-lift branch from 0f4523b to 6c5a533 Compare April 25, 2024 14:18
@cpcloud cpcloud requested a review from gforsyth April 25, 2024 14:20
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good on the pyspark front -- going to need a bunch of notyets on the test

@cpcloud cpcloud force-pushed the array-zip-unnest-lift branch from 6c5a533 to cc1a40e Compare April 25, 2024 15:58
Co-authored-by: Gil Forsyth <gforsyth@users.noreply.github.com>
@cpcloud cpcloud requested a review from gforsyth April 25, 2024 17:01
@cpcloud cpcloud enabled auto-merge (squash) April 25, 2024 17:01
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@cpcloud cpcloud merged commit be9d5da into ibis-project:main Apr 25, 2024
82 checks passed
@cpcloud cpcloud deleted the array-zip-unnest-lift branch April 25, 2024 17:02
@cpcloud
Copy link
Member Author

cpcloud commented Apr 25, 2024

Suppose I should've tested the clouds…

Let's see what happens.

@gforsyth
Copy link
Member

eh, one bigquery failure but it looks flaky to me (and not the test you added)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis datatypes Issues relating to ibis's datatypes (under `ibis.expr.datatypes`) pyspark The Apache PySpark backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Throw FIELD_NOT_FOUND exception when lift a struct
2 participants