feat(postgres): add mappings for more esoteric dtypes #9055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shows up in some of the default postgis tables. Adding it so that those tables can be loaded.
Postgres has special datatypes used in their information schema table. Users should be able to load these tables. Custom types are listed here: https://www.postgresql.org/docs/current/infoschema-datatypes.html
gforsyth
force-pushed
the
postgres/nametype
branch
from
f57513e to
487c3d3
Compare
cpcloud
reviewed
Apr 25, 2024
| "name": dt.string, | ||
| # information schema dtypes | ||
| # defined as nonnegative int | ||
| "information_schema.cardinal_number": dt.uint64, |
cpcloud
reviewed
Apr 25, 2024
| # "domain over type `timestamp with time zone`" | ||
| "information_schema.time_stamp": dt.timestamp, | ||
| # the pre-bool version of bool kept for backwards compatibility | ||
| "information_schema.yes_or_no": dt.string, |
cpcloud
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8845
Postgres'
information_schemahas a few custom dtypes that are only used there. Most of them just map to stringlike things, but users should be able to load these tables without issue.I also added a mapping for the
nametype, which shows up in some of the default tables inpostgis.