docs: update sankey diagram #9077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
don't like the PNG, let me play with that |
lostmygithubaccount
added
docs
ibis-docs-bot
bot
removed
the
docs-preview
|
I like the colors and change to 2 categories, but it's way harder to read. going back to draft mode |
lostmygithubaccount
added
the
docs-preview
|
it's better now IMO |
ibis-docs-bot
bot
removed
the
docs-preview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
this started as trying to get dynamic light/dark mode for plotting (with the sankey diagram, but any) working with Quarto. I still couldn't figure it out. there's definitely a path that's like save both versions of the image and use JavaScript to dynamically load the right one. another option, if we could get the HTML for the page in Python, would be to use that
so anyway, this actually just updates the sankey diagram to put it in a funciton to choose light/dark mode, minor code improvements, and improving the colors
one suggestion from Jim was simplifying the cateogires and I agree, so now it's just SQL/DataFrame
Issues closed