fix(duckdb): load extension when executing geospatial expressions

[ncclementi]

• Closes bug(geo-duckdb): ibis.read_parquet() binary cast to geometry  #9076

[cpcloud]

If you're going to use a custom extension directory you need to produce a new one specific to this test call.

As is, ext_dir is a session-level fixture, which means that if another test runs before this one that happens to install the geospatial extension then you're not testing the thing that needs to be tested (or its success is implicitly depending on the fact that another test ran before it, and that'll lead to a flaky test), which is that geospatial operations load the extension.

[ncclementi]

I want to be able have a new connection that doesn't have the extension loaded. I was following what we did here

ibis/ibis/backends/duckdb/tests/test_geospatial.py

Lines 322 to 334 in fead40b

	@pytest.fixture(scope="session")
	def ext_dir(tmp_path_factory):
	# this directory is necessary because of Windows extension downloads race
	# condition
	return tmp_path_factory.mktemp("extensions")
	def test_geo_unop_geo_literals(ext_dir, geo_line_lit):
	"""GeoSpatialUnOp operation on a geospatial literal"""
	con = ibis.duckdb.connect(extension_directory=ext_dir)
	expr = geo_line_lit.length()
	assert con.execute(expr) == 2

Which sounds like it's also being missed used here too? I can scope it to "function", though I'm not sure that's the path we want.

[cpcloud]

Which sounds like it's also being missed used here too?

Probably 😅

If you change the fixture decorator from

@pytest.fixture(scope="session")

to

@pytest.fixture

that should be sufficient (no scope="function" necessary).