feat(duckdb): add catalog support to create_table #9147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gforsyth
commented
May 7, 2024
Comment on lines
+33
to
+68
| def test_read_write_external_catalog(con, external_duckdb_file, monkeypatch): | ||
| monkeypatch.setattr(ibis.options, "default_backend", con) | ||
|
|
||
| ddb_path, starwars_df = external_duckdb_file | ||
| con.attach(ddb_path, name="ext") | ||
|
|
||
| # Read from catalog | ||
| assert "ext" in con.list_catalogs() | ||
| assert "main" in con.list_databases(catalog="ext") | ||
|
|
||
| assert "starwars" in con.list_tables(database="ext.main") | ||
| assert "starwars" not in con.list_tables() | ||
|
|
||
| starwars = con.table("starwars", database="ext.main") | ||
| tm.assert_frame_equal(starwars.to_pandas(), starwars_df) | ||
|
|
||
| # Write to catalog | ||
| t = ibis.memtable([{"a": 1, "b": "foo"}, {"a": 2, "b": "baz"}]) | ||
|
|
||
| _ = con.create_table("t2", obj=t, database="ext.main") | ||
|
|
||
| assert "t2" in con.list_tables(database="ext.main") | ||
| assert "t2" not in con.list_tables() | ||
|
|
||
| table = con.table("t2", database="ext.main") | ||
|
|
||
| tm.assert_frame_equal(t.to_pandas(), table.to_pandas()) | ||
|
|
||
| # Overwrite table in catalog | ||
|
|
||
| t_overwrite = ibis.memtable([{"a": 8, "b": "bing"}, {"a": 9, "b": "bong"}]) | ||
|
|
||
| _ = con.create_table("t2", obj=t_overwrite, database="ext.main", overwrite=True) | ||
|
|
||
| assert "t2" in con.list_tables(database="ext.main") | ||
| assert "t2" not in con.list_tables() | ||
|
|
||
| table = con.table("t2", database="ext.main") | ||
|
|
||
| tm.assert_frame_equal(t_overwrite.to_pandas(), table.to_pandas()) |
There was a problem hiding this comment.
I'd like to break this up into separate tests, but there are locking issues when attaching to the same external source -- I'm sure we can work around it, but I think this is good enough for now.
There was a problem hiding this comment.
you could design the tests to run in isolation by creating and tearing down separate external sources for each test case, though this might increase test execution time.
cpcloud
reviewed
May 7, 2024
|
|
||
| yield ddb_path, starwars_df | ||
|
|
||
| Path(ddb_path).unlink() |
There was a problem hiding this comment.
I would just let it live. It's in a temp dir, that seems good enough for now.
There was a problem hiding this comment.
alternatively you can try to delete and ignore the error, but i think leaving the file around is fine too
cpcloud
reviewed
May 7, 2024
cpcloud
force-pushed
the
ibis-duckdb-catalog
branch
from
e8d2405 to
b7d32af
Compare
feat(duckdb): add catalog support to DuckDB create_table This adds support for creating tables in external catalogs using DuckDB. External catalogs cover attached SQLite, Postgres, and MySQL databases, as well as attached DuckDB files.
cpcloud
force-pushed
the
ibis-duckdb-catalog
branch
from
b7d32af to
6394149
Compare
cpcloud
added
ddl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(duckdb): add catalog support to DuckDB create_table
This adds support for creating tables in external catalogs using DuckDB.
External catalogs cover attached SQLite, Postgres, and MySQL databases,
as well as attached DuckDB files.
Resolves #9146