feat(pyspark): implement new experimental read/write directory methods #9272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
chloeh13q
force-pushed
the
feat/spark-new-read-write
branch
from
b008b1f to
c9ef6df
Compare
cpcloud
reviewed
May 31, 2024
cpcloud
reviewed
Jun 3, 2024
| @@ -360,6 +325,7 @@ def con(data_dir, tmp_path_factory, worker_id): | |||
| @pytest.fixture(scope="session") | |||
| def con_streaming(data_dir, tmp_path_factory, worker_id): | |||
| backend_test = TestConfForStreaming.load_data(data_dir, tmp_path_factory, worker_id) | |||
| backend_test._load_data() | |||
There was a problem hiding this comment.
Not 100% sure why this is needed, let me investigate a bit what's going on.
There was a problem hiding this comment.
I figured out what the problem is! The pyspark backend loads statefully and the streaming conf ended up reusing the same temp directory from the batch conf, which already exists when the batch conf tried to load data, so the streaming conf skips data loading. Because tmpdir is passed as a fixture, I added a line of code that changes the directory naming for the streaming conf.
chloeh13q
force-pushed
the
feat/spark-new-read-write
branch
from
76f613b to
206cd9c
Compare
cpcloud
force-pushed
the
feat/spark-new-read-write
branch
from
206cd9c to
3093145
Compare
chloeh13q
force-pushed
the
feat/spark-new-read-write
branch
from
d51bd42 to
f933779
Compare
chloeh13q
force-pushed
the
feat/spark-new-read-write
branch
from
85317b3 to
4f03594
Compare
chloeh13q
force-pushed
the
feat/spark-new-read-write
branch
from
3237871 to
6bc9364
Compare
cpcloud
reviewed
Jun 27, 2024
cpcloud
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Implement new experimental read/write directory methods in Pyspark backend to support streaming read/write.
Issues closed
#8984