-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add ibis-bench blog #9391
docs: add ibis-bench blog #9391
Conversation
still a work in progress, opening for feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments for now, will review more thoroughly next week!
It'd be good to explicitly say somewhere that this is not an official TPC-H benchmark. |
it is buried in there, I'll do something more explicit. datafusion has some explicit language I could |
@cpcloud @ianmcook updated if you can re-review. also shared in communities for any final feedback, hoping to push this on Monday direct preview link: https://pr-9391-8a1496ef180e22c9cd9817c307607e7aa761fe68--ibis-quarto.netlify.app/posts/ibis-bench/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments/suggested edits.
docs/posts/ibis-bench/index.qmd
Outdated
across 8 tables. The queries are designed to test the performance of a database | ||
(or dataframe!) on a variety of tasks including filtering, aggregation, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
across 8 tables. The queries are designed to test the performance of a database | |
(or dataframe!) on a variety of tasks including filtering, aggregation, and | |
across 8 tables. The queries are designed to test the performance of a query engine | |
on a variety of tasks including filtering, aggregation, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree with this change -- TPC-H is clearly initially designed for databases, and I want to make the point (perhaps more explicitly somewhere) that Ibis brings the best of database technology including query engines to dataframes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, but the parenthetical seems out of place to me here then. Why point out the parenthetical if it's specifically designed for databases? Seems distracting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also isn't blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how's:
The SQL (or dataframe) code representing the queries is
designed to test the performance of a query engine on a variety of tasks
including filtering, aggregation, and joins.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just don't like parentheticals. What value is it adding here?
Description of changes
create a blog on Ibis benchmarking with
ibis-bench
Issues closed