Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add ibis-bench blog #9391

Merged
merged 8 commits into from
Jun 24, 2024

Conversation

lostmygithubaccount
Copy link
Member

Description of changes

create a blog on Ibis benchmarking with ibis-bench

Issues closed

@lostmygithubaccount lostmygithubaccount added the docs Documentation related issues or PRs label Jun 14, 2024
@lostmygithubaccount
Copy link
Member Author

still a work in progress, opening for feedback

@lostmygithubaccount lostmygithubaccount marked this pull request as draft June 14, 2024 18:34
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jun 14, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jun 14, 2024
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jun 14, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jun 14, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Jun 14, 2024

Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments for now, will review more thoroughly next week!

docs/posts/ibis-bench/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-bench/index.qmd Show resolved Hide resolved
docs/posts/ibis-bench/index.qmd Outdated Show resolved Hide resolved
@cpcloud cpcloud added this to the 9.2 milestone Jun 15, 2024
@cpcloud cpcloud added performance Issues related to ibis's performance blog Posts for the Ibis blog. labels Jun 15, 2024
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jun 18, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jun 18, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Jun 18, 2024

@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jun 18, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jun 18, 2024
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Jun 18, 2024

@ianmcook
Copy link
Contributor

It'd be good to explicitly say somewhere that this is not an official TPC-H benchmark.

@lostmygithubaccount
Copy link
Member Author

It'd be good to explicitly say somewhere that this is not an official TPC-H benchmark.

it is buried in there, I'll do something more explicit. datafusion has some explicit language I could steal reuse: https://github.com/apache/datafusion-benchmarks?tab=readme-ov-file#tpc-legal-considerations

docs/posts/ibis-bench/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-bench/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-bench/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-bench/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-bench/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-bench/index.qmd Outdated Show resolved Hide resolved
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jun 21, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jun 21, 2024
@lostmygithubaccount lostmygithubaccount marked this pull request as ready for review June 21, 2024 15:43
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Jun 21, 2024

@lostmygithubaccount
Copy link
Member Author

lostmygithubaccount commented Jun 21, 2024

@cpcloud @ianmcook updated if you can re-review. also shared in communities for any final feedback, hoping to push this on Monday

direct preview link: https://pr-9391-8a1496ef180e22c9cd9817c307607e7aa761fe68--ibis-quarto.netlify.app/posts/ibis-bench/

Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments/suggested edits.

docs/posts/ibis-bench/index.qmd Outdated Show resolved Hide resolved
Comment on lines 31 to 32
across 8 tables. The queries are designed to test the performance of a database
(or dataframe!) on a variety of tasks including filtering, aggregation, and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
across 8 tables. The queries are designed to test the performance of a database
(or dataframe!) on a variety of tasks including filtering, aggregation, and
across 8 tables. The queries are designed to test the performance of a query engine
on a variety of tasks including filtering, aggregation, and

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree with this change -- TPC-H is clearly initially designed for databases, and I want to make the point (perhaps more explicitly somewhere) that Ibis brings the best of database technology including query engines to dataframes

Copy link
Member

@cpcloud cpcloud Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, but the parenthetical seems out of place to me here then. Why point out the parenthetical if it's specifically designed for databases? Seems distracting.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also isn't blocking.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how's:

The SQL (or dataframe) code representing the queries is
designed to test the performance of a query engine on a variety of tasks
including filtering, aggregation, and joins.

?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just don't like parentheticals. What value is it adding here?

docs/posts/ibis-bench/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-bench/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-bench/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-bench/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-bench/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-bench/index.qmd Show resolved Hide resolved
docs/posts/ibis-bench/index.qmd Outdated Show resolved Hide resolved
docs/posts/ibis-bench/index.qmd Outdated Show resolved Hide resolved
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jun 24, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jun 24, 2024
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jun 24, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jun 24, 2024
@lostmygithubaccount lostmygithubaccount added the docs-preview Add this label to trigger a docs preview label Jun 24, 2024
@ibis-docs-bot ibis-docs-bot bot removed the docs-preview Add this label to trigger a docs preview label Jun 24, 2024
@lostmygithubaccount lostmygithubaccount enabled auto-merge (squash) June 24, 2024 14:24
@lostmygithubaccount lostmygithubaccount merged commit 2c9198d into ibis-project:main Jun 24, 2024
20 checks passed
@ibis-docs-bot
Copy link

ibis-docs-bot bot commented Jun 24, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blog Posts for the Ibis blog. docs Documentation related issues or PRs performance Issues related to ibis's performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants