-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(blog): run Ibis on Snowflake #9406
Conversation
ACTION NEEDED Ibis follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
b7e7776
to
17d0f49
Compare
This is still a WIP, but I wanted to get this out here so that we can collaborate via PR and ensure the structure of the post is on the right track. |
… notes in a callout-info box
@IndexSeek Thanks! I pushed up some changes explaining how the thing works, linking to various places for more information. |
Thank you @cpcloud! These modifications and additions were great. I made some slight tweaks to the phrasing around the more permanent solution. I want readers to know that it is possible, but I want to avoid making any promises or setting expectations that this would be made available directly from Ibis. |
As I reread this, I realized that the note I had included: "Now we can upload these packages and make them available" was abrupt and lacked clarity on why it's necessary. I included a small snippet showing the sproc registration to include the other dependencies as well, which may encourage readers to try it themselves. I am happy to tweak this if it's too much code/too specific. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One incredibly small, non-blocking language nit.
Co-authored-by: Gil Forsyth <gforsyth@users.noreply.github.com>
@IndexSeek Once you're ready to ship this, please mark it as Ready for review, we'll merge it! |
This PR aims to create a post to tell the story about how we were able to get Ibis running inside Snowflake, fulfilling the reference in
ibis/docs/posts/ibis-version-9.0.0-release/index.qmd
Lines 135 to 136 in bdc1b3f
This all ties back to #5877, with the resolution made possible thanks to the effort from converting to SQLGlot from SQLAlchemy.