Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: mssql does not implement _from_url() #9415

Closed
1 task done
grieve54706 opened this issue Jun 21, 2024 · 6 comments · Fixed by #9894
Closed
1 task done

bug: mssql does not implement _from_url() #9415

grieve54706 opened this issue Jun 21, 2024 · 6 comments · Fixed by #9894
Assignees
Labels
bug Incorrect behavior inside of ibis mssql The Microsoft SQL Server backend onboarding Issues that can be addressed by someone less familiar with ibis

Comments

@grieve54706
Copy link
Contributor

What happened?

The document website has a description of the MSSQL that could use a connection URL to connect.
https://ibis-project.org/backends/mssql#ibis.connect-url-format

But actually backends.mssql inherits NoUrl and does not implement _from_url().

What version of ibis are you using?

9.0.0

What backend(s) are you using, if any?

MSSQL

Relevant log output

self = <ibis.backends.mssql.Backend object at 0x1388b0490>, host = 'localhost'
user = None, password = None, port = 1433, database = None, driver = None
kwargs = {'Trusted_Connection': 'yes'}

    def do_connect(
        self,
        host: str = "localhost",
        user: str | None = None,
        password: str | None = None,
        port: int = 1433,
        database: str | None = None,
        driver: str | None = None,
        **kwargs: Any,
    ) -> None:
        if user is None and password is None:
            kwargs.setdefault("Trusted_Connection", "yes")

>       con = pyodbc.connect(
            user=user,
            server=host,
            port=port,
            password=password,
            database=database,
            driver=driver,
            **kwargs,
        )
E       pyodbc.Error: ('01000', "[01000] [unixODBC][Driver Manager]Can't open lib 'None' : file not found (0) (SQLDriverConnect)")

Code of Conduct

  • I agree to follow this project's Code of Conduct
@grieve54706 grieve54706 added the bug Incorrect behavior inside of ibis label Jun 21, 2024
@cpcloud cpcloud changed the title bug: mssql is not implement _from_url() bug: mssql does not implement _from_url() Jun 21, 2024
@gforsyth gforsyth added mssql The Microsoft SQL Server backend onboarding Issues that can be addressed by someone less familiar with ibis labels Jul 13, 2024
@gforsyth
Copy link
Member

Hey @grieve54706 -- thanks for opening this! This seems like a good starter issue for a new contributor, so we might leave it open for a little while, but I'm sure someone will pick it up eventually.

Let us know if it becomes a blocker for you!

@grieve54706
Copy link
Contributor Author

Hi @gforsyth,

I wish I had the time to help implement this feature. Would you mind if I submit a PR to fix it when I have some free time?

@gforsyth
Copy link
Member

Hey @grieve54706! Definitely! It's possible someone else might pick it up, but I'm happy to wait on it.

@pangeran-bottor
Copy link

hi @grieve54706, have you already started working on this? if not and if it's ok, I would like to take on this

@grieve54706
Copy link
Contributor Author

Hi @pangeran-bottor, I'm not ready. You can take this. Thank you for your time and help.

@cpcloud
Copy link
Member

cpcloud commented Aug 22, 2024

Closed by #9894.

@cpcloud cpcloud closed this as completed Aug 22, 2024
@github-project-automation github-project-automation bot moved this from backlog to done in Ibis planning and roadmap Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis mssql The Microsoft SQL Server backend onboarding Issues that can be addressed by someone less familiar with ibis
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants