refactor(api): remove tuple support in SortKey
#9416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncclementi
reviewed
Jun 21, 2024
cpcloud
force-pushed
the
remove-tuple-in-sort-keys
branch
from
a596ada to
592986d
Compare
jcrist
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Fine by me.
Did we deliberately break support for tuple[Column, bool] as SortKey descriptions? This is indeed broken on main, but I don't remember this being an intentional decision to drop support (and would have thought we'd have an expression-level test for this).
In [1]: import ibis
In [2]: t = ibis.table({"x": "string", "y": "string"})
In [3]: t.order_by((t.x, False)) # this used to coerce to a descending sort by x IIRC
Out[3]:
r0 := UnboundTable: unbound_table_0
x string
y string
Sort[r0]
asc r0.x
asc False
|
I don't think this was intentional. I am also surprised that we had no tests for this. |
|
I'm fine not fixing/readding it. |
|
Possibly this change has disabled that code path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a code path to handle tuples in
ops.SortKey. This code path is apparently never hit (thanks to @ncclement for noticing this) and so has not worked for a while. Therefore, I decided to not mark this as a breaking change.Closes #9413.