Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tests): add tpc ds setup and rearrange tpc setup #9453

Merged
merged 6 commits into from
Jun 27, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jun 27, 2024

This PR adds support for testing TPC-DS queries for correctness against the
handwritten DuckDB SQL in basically the same way that we do now for TPC-H.

The methodology is shared across H and DS query sets.

@cpcloud cpcloud added this to the 9.2 milestone Jun 27, 2024
@cpcloud cpcloud added refactor Issues or PRs related to refactoring the codebase tests Issues or PRs related to tests labels Jun 27, 2024
@cpcloud cpcloud force-pushed the tpc-ds-setup branch 3 times, most recently from 027c51f to 241c1a3 Compare June 27, 2024 14:09
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

ibis/backends/tests/tpc/conftest.py Outdated Show resolved Hide resolved
Co-authored-by: Gil Forsyth <gforsyth@users.noreply.github.com>
@cpcloud cpcloud merged commit b150635 into ibis-project:main Jun 27, 2024
77 checks passed
@cpcloud cpcloud deleted the tpc-ds-setup branch June 27, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues or PRs related to refactoring the codebase tests Issues or PRs related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants