Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(clickhouse): add TPC-H and TPC-DS queries #9508

Merged
merged 1 commit into from
Jul 15, 2024
Merged

test(clickhouse): add TPC-H and TPC-DS queries #9508

merged 1 commit into from
Jul 15, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jul 3, 2024 •
edited
Loading

Adds TPC-H and TPC-DS testing to clickhouse.

Depends on #9525.

@cpcloud cpcloud added this to the 9.2 milestone Jul 3, 2024
@cpcloud cpcloud added the tests Issues or PRs related to tests label Jul 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024

ACTION NEEDED

Ibis follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message.

Please update your PR title and description to match the specification.

@cpcloud cpcloud changed the title clickhouse tpc tests(clickhouse): add TPC-H and TPC-DS queries Jul 3, 2024
@cpcloud cpcloud changed the title tests(clickhouse): add TPC-H and TPC-DS queries test(clickhouse): add TPC-H and TPC-DS queries Jul 3, 2024
@cpcloud
Copy link
Member Author

cpcloud commented Jul 3, 2024

I will break out a fix or two from this PR into a separate PR.

@cpcloud cpcloud force-pushed the clickhouse-tpc branch 2 times, most recently from a995ca1 to 57dcc47 Compare July 4, 2024 11:54
@cpcloud cpcloud added the clickhouse The ClickHouse backend label Jul 4, 2024
@cpcloud cpcloud force-pushed the clickhouse-tpc branch 2 times, most recently from dc56e4a to 59530bb Compare July 5, 2024 12:00
@cpcloud cpcloud mentioned this pull request Jul 5, 2024
Merged
gforsyth pushed a commit that referenced this pull request Jul 13, 2024
@cpcloud
fix(clickhouse): generate redundant aliases to workaround clickhouse …
b44dac2 
…naming behavior (#9525)

Found during #9508.

This PR works around an apparent upstream bug in ClickHouse where
right-side join operand column references are not correctly recognized.
@cpcloud cpcloud requested review from gforsyth and jcrist July 15, 2024 13:15
jcrist
jcrist approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM!

ibis/backends/clickhouse/compiler.py Outdated Show resolved Hide resolved
@cpcloud cpcloud enabled auto-merge (squash) July 15, 2024 15:38
@cpcloud cpcloud merged commit ef4e47b into ibis-project:main Jul 15, 2024
82 checks passed
@cpcloud cpcloud deleted the clickhouse-tpc branch July 15, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcrist jcrist jcrist approved these changes

@gforsyth gforsyth Awaiting requested review from gforsyth

Assignees
No one assigned
Labels
clickhouse The ClickHouse backend tests Issues or PRs related to tests
Projects
None yet
Milestone
9.2
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @jcrist