Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(viz): avoid repeatedly rendering redundant schemas in graphviz output #9518

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jul 4, 2024

Avoids rendering schemas for Simple relations in graphviz output, which are the relations that do not alter their schema in any way.

@cpcloud cpcloud added this to the 9.2 milestone Jul 4, 2024
@cpcloud cpcloud added the ux User experience related issues label Jul 4, 2024
@cpcloud cpcloud force-pushed the dont-render-schema-so-many-times branch from 4e3987b to 2f3ef8d Compare July 4, 2024 15:00
@cpcloud cpcloud modified the milestone: 9.2 Jul 15, 2024
@cpcloud cpcloud requested review from jcrist and gforsyth July 18, 2024 12:34
@gforsyth
Copy link
Member

A non-trivial query:

Before:
tmp65zr3_jm

After:
tmphnxtrvnj

This seems a bit cleaner to me? Thoughts?

@cpcloud cpcloud merged commit d53602b into ibis-project:main Jul 19, 2024
76 checks passed
@cpcloud cpcloud deleted the dont-render-schema-so-many-times branch July 19, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux User experience related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants