fix(clickhouse): generate redundant aliases to workaround clickhouse naming behavior #9525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
commented
Jul 5, 2024
| @@ -350,7 +351,7 @@ def test_create_table_no_syntax_error(con): | |||
|
|
|||
|
|
|||
| def test_password_with_bracket(): | |||
| password = f'{os.environ.get("IBIS_TEST_CLICKHOUSE_PASSWORD", "")}[' | |||
| password = f'{os.environ.get("IBIS_TEST_CLICKHOUSE_PASSWORD", "")}[]' | |||
There was a problem hiding this comment.
I changed this because an unmatched [ messes with neovim indentation.
cpcloud
added
bug
|
Reported upstream here: ClickHouse/ClickHouse#66133 |
cpcloud
force-pushed
the
workaround-upstream-clickhouse-aliasing-bug
branch
2 times, most recently
from
cce2f32 to
2d3a38a
Compare
cpcloud
force-pushed
the
workaround-upstream-clickhouse-aliasing-bug
branch
from
2d3a38a to
3b4cfbe
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found during #9508.
This PR works around an apparent upstream bug in ClickHouse where right-side join operand column references are not correctly recognized.