Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(caching): remove parameters that are always the same #9532

Merged
merged 1 commit into from
Jul 9, 2024
Merged

refactor(caching): remove parameters that are always the same #9532

merged 1 commit into from
Jul 9, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jul 6, 2024

Remove some unnecessary parameters from RefCountedCache

@cpcloud cpcloud added this to the 9.2 milestone Jul 6, 2024
@cpcloud cpcloud added internals Issues or PRs related to ibis's internal APIs refactor Issues or PRs related to refactoring the codebase labels Jul 6, 2024
gforsyth
gforsyth approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gforsyth gforsyth merged commit afa2848 into ibis-project:main Jul 9, 2024
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gforsyth gforsyth gforsyth approved these changes

Assignees
No one assigned
Labels
internals Issues or PRs related to ibis's internal APIs refactor Issues or PRs related to refactoring the codebase
Projects
None yet
Milestone
9.2
Development

Successfully merging this pull request may close these issues.
2 participants
@cpcloud @gforsyth