fix(bigquery): escape table names with spaces for bigquery backend

[akanz1]

Description of changes

bigquery docs "[Identifiers] Must be enclosed by backtick (`) characters."

• enclose table names with backticks to avoid failures when spaces are included
• remove L.586 as it appears to be redundant (see L.551)
• fix typo

Issues closed

• Resolves bug: bigquery backend fails for tables with spaces in table name #9588

[gforsyth]

Hey @akanz1, thanks for the bug report and the PR!!

Two questions for you:

1. Can you add a simple test for this? I think creating a table with a space in the name, and then demonstrating that we can grab a reference to it is sufficient.
2. Should we include a check that name isn't already quoted with backticks? I don't think double-backticks are valid (or at least sqlglot doesn't like them)

Invalid reason for requesting changes

[cpcloud]

I don't think we should include a check for already quoted things. We don't allow backend specific quoting for name in any backends AFAIK. If we do, we should fix that :)

[akanz1]

Hey @akanz1, thanks for the bug report and the PR!!

Two questions for you:

1. Can you add a simple test for this? I think creating a table with a space in the name, and then demonstrating that we can grab a reference to it is sufficient.
2. Should we include a check that name isn't already quoted with backticks? I don't think double-backticks are valid (or at least sqlglot doesn't like them)

I'll probably need to go through the projects dev setup and have a look at how you test similar cases. If you can point me to an example that would be great, I'll likely get to it later this week.

[gforsyth]

Hi @akanz1 -- we have a test for Bigquery for creating temp tables -- you can look at ibis/backends/bigquery/tests/system/test_client.py::test_create_temp_table_from_scratch

You can do something similar there, but with the name being something like f"spacetest {gen_name("bigquery_space_table")}"

That will confirm that we can create tables that have spaces in the names (might need to add handling for that to create_table), and then you can add an additional check of grabbing the table object with t = con.table(f"spacetest {gen_name("bigquery_space_table")}"

You will also want to set the env-var $PROJECT_ID_ENV_VAR to a bigquery project id that you have credentials for, otherwise it will default to the one used by our test suite, which will throw an auth error.

[cpcloud]

Pushed up a test so we can get this out in 9.2

[cpcloud]

BigQuery tests are passing:

…/ibis on  akanz1/main:main is 📦 v9.1.0 via 🐍 v3.10.14 via ❄️   impure (ibis-3.10.14-env)
❯ pytest -m bigquery -n auto --dist loadgroup -q
bringing up nodes...
...........................................................x.....x.....sssssssssssssssssssssssssssx......................x...............sssssssssssssssssssss..............................xx [  9%]
xxx...x..x.xx.xx.xxx.xxxxxxxxxxxxxxxx.xxxxxxxxx.xxx.xxx.xxxxxx.xxxxxxxxxxxxxxxxxxxx.xxxxxxxxxxxxx.x.xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx.xx..xx......xx......x..x..xx.......x..... [ 19%]
....................x.......x.xxx.x..xx..xx.xx..x...xx....x.......x.......x.....xx.x...x.x..x.x.......xx.xx.xxxx.....xx.xx..x..xx..x.x.x.x..x.x........x.x...........xxx..............x....... [ 28%]
x....x.....x...x.x.......x........x...x...........................x.x....................x.......x..........xx...............x.x..........x...x.....x......xx...xx.....x...........x.......x.. [ 38%]
.................x......x..........................x...............xx.............x..x...x.......x.x....x.....x...........xx.......................x..........x......x.x....x.x..x......x.x.x. [ 47%]
....x.........x.................x...x..........x.x.....x.....xx.......x...x...x.......x.............x.......x...x..............x....xx..xx............x....x.x.x............x.............x.x. [ 57%]
.x.x...x.......xx..x........xx.x.x..........x........x......x...x..x.....x.......x..x..........x.......x............x.xx...x..x.....xx......x.x.........xx............x..x.x.........x..x..x.. [ 66%]
......x....x.......s.x...x.x.....x.......x..x...........x..s..x..s........xxs..........x..........x..x..s......................x..............ss...................s......x................... [ 76%]
..............................................x...................x........................................................................................................................... [ 85%]
............................................................................................................x................................................................................. [ 95%]
...................................................x.....................................                                                                                                      [100%]
1597 passed, 56 skipped, 336 xfailed in 362.23s (0:06:02)

[cpcloud]

This only touches the BigQuery backend, and the bigquery compiler tests pass, so merging!

[cpcloud]

@akanz1 Thanks for the PR!

[akanz1]

Awesome, thanks a lot guys!