refactor(compilers): move compilers out of the backend dependency path #9590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
feature
cpcloud
force-pushed
the
consolidate-compilers
branch
from
a2a4c9e to
57103a9
Compare
gforsyth
approved these changes
Jul 15, 2024
|
Ahh, looks like we just need to update this import: from ibis.backends.sql.compiler import ALL_OPERATIONSin the support matrix generation script |
cpcloud
force-pushed
the
consolidate-compilers
branch
from
27e1a3d to
e031937
Compare
cpcloud
commented
Jul 15, 2024
| @@ -136,6 +135,8 @@ def visit_Cast(self, op, *, arg, to): | |||
| if to.is_timestamp(): | |||
| return self._to_timestamp(arg, to) | |||
| if to.is_decimal(): | |||
| from ibis.formats.pyarrow import PyArrowType | |||
|
|
|||
| return self.f.arrow_cast(arg, f"{PyArrowType.from_ibis(to)}".capitalize()) | |||
There was a problem hiding this comment.
This isn't 100% free of dependencies here, because we're using the pyarrow type system for casts, because datafusion doesn't have any other way to represent types than their pyarrow string representation. So, unfortunately, if you're converting from non-datafusion dialects to datafusion then you'll need pyarrow installed.
There was a problem hiding this comment.
I think this is a big improvement and this will only trip up users if they are going from non-datafusion dialects to datafusion AND if they have decimal columns. 
There was a problem hiding this comment.
Yep, it's a somewhat specific use case I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the compilers out of the path of backend-specific dependencies, to allow using them with a base installation of Ibis. cc @jonmmease