Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): accept more input types in ibis.range #9659

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jul 22, 2024

Closes #9557.

@cpcloud cpcloud added bug Incorrect behavior inside of ibis feature Features or general enhancements ux User experience related issues timestamps Issues related to the timestamp API labels Jul 22, 2024
@cpcloud cpcloud requested a review from jcrist July 22, 2024 16:14
@cpcloud cpcloud added this to the 9.2 milestone Jul 22, 2024
@cpcloud cpcloud enabled auto-merge (squash) July 22, 2024 16:22
@cpcloud
Copy link
Member Author

cpcloud commented Jul 22, 2024

Ok, looks like I, uh, didn't add very many API level tests the first time around. I'll add some that aren't just doctests 😬

@cpcloud cpcloud merged commit 310ad30 into ibis-project:main Jul 22, 2024
82 checks passed
@cpcloud cpcloud deleted the exprs-in-range branch July 22, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis feature Features or general enhancements timestamps Issues related to the timestamp API ux User experience related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(timestamps): ibis.range doesn't accept ibis.timestamp objects (ibis expressions)
2 participants