refactor(table_loc): return consistent object from catalog.db parsing #9743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gforsyth
added
the
ci-run-cloud
ibis-docs-bot
bot
removed
the
ci-run-cloud
cpcloud
approved these changes
Aug 1, 2024
cpcloud
added
the
ci-run-cloud
ibis-docs-bot
bot
removed
the
ci-run-cloud
The previous `return None` short-circuit led to a bunch of `is None` checks across the codebase. If we always have a `sg.exp.Table`, even if the fields are set to `None`, we can simplify those checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The previous
return Noneshort-circuit led to a bunch ofis Nonechecks across the codebase. If we always have a
sg.exp.Table, even ifthe fields are set to
None, we can simplify those checks.Issues closed
This is a small part of #9742