Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pandas): remove unreachable code in pandas backend #9786

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

mesejo
Copy link
Contributor

@mesejo mesejo commented Aug 7, 2024

Description of changes

Remove unreachable code in the pandas' Backend that could be confusing

Copy link
Member

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! Thanks.

Was there a tool you used to discover this?

@cpcloud cpcloud changed the title fix: remove unreachable code in pandas backend refactor(pandas): remove unreachable code in pandas backend Aug 7, 2024
@cpcloud cpcloud added refactor Issues or PRs related to refactoring the codebase pandas The pandas backend labels Aug 7, 2024
@cpcloud cpcloud added this to the 9.3 milestone Aug 7, 2024
@mesejo
Copy link
Contributor Author

mesejo commented Aug 7, 2024

Nice find! Thanks.

Was there a tool you used to discover this?

I was perusing around the code, and the IDE (JetBrains Pycharm) marked it as unreachable

@cpcloud cpcloud merged commit dc6bfe2 into ibis-project:main Aug 7, 2024
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pandas The pandas backend refactor Issues or PRs related to refactoring the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants