Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ux): allow window functions in predicates and compile to QUALIFY where possible #9787

Merged
merged 5 commits into from
Aug 7, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Aug 7, 2024

Closes #9775.

Copy link
Contributor

github-actions bot commented Aug 7, 2024

ACTION NEEDED

Ibis follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message.

Please update your PR title and description to match the specification.

@cpcloud cpcloud changed the title qualify feat(ux): allow window functions in predicates and compile to QUALIFY where possible Aug 7, 2024
@cpcloud
Copy link
Member Author

cpcloud commented Aug 7, 2024

Ideally we can get this in for 9.3, but if it turns out to be a huge pain then we can of course wait.

@cpcloud cpcloud added this to the 9.3 milestone Aug 7, 2024
@cpcloud cpcloud added internals Issues or PRs related to ibis's internal APIs ux User experience related issues window functions Issues or PRs related to window functions labels Aug 7, 2024
@cpcloud cpcloud requested review from jcrist and gforsyth August 7, 2024 15:30
@cpcloud cpcloud added the ci-run-cloud Add this label to trigger a run of BigQuery, Snowflake, and Databricks backends in CI label Aug 7, 2024
@ibis-docs-bot ibis-docs-bot bot removed the ci-run-cloud Add this label to trigger a run of BigQuery, Snowflake, and Databricks backends in CI label Aug 7, 2024
Copy link
Member

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@cpcloud cpcloud enabled auto-merge (squash) August 7, 2024 19:10
@cpcloud cpcloud merged commit 0370bcb into ibis-project:main Aug 7, 2024
82 checks passed
@cpcloud cpcloud deleted the qualify branch August 7, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Issues or PRs related to ibis's internal APIs ux User experience related issues window functions Issues or PRs related to window functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Support QUALIFY syntax to filter on analytic expression
2 participants