-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(snowflake): fix the syntax for passing schema #9831
Conversation
@@ -119,7 +120,8 @@ APIs. All values of `authenticator` are supported. | |||
con = ibis.snowflake.connect( | |||
user="user", | |||
account="safpqpq-sq55555", | |||
database="my_database/my_schema", | |||
database="my_database", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
database="my_database", | |
database="my_catalog/my_database", |
Does it make sense to have something like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, probably not. The idea is to do as little customization here so we can just dump kwargs to the underlying connector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, what I meant is, based on https://github.com/ibis-project/ibis/blob/9.3.0/ibis/backends/snowflake/tests/test_client.py#L411-L412, it seems like you can pass in the form database="catalog/database"
. However, this isn't as clear from the examples, so I was wondering if it makes sense to document it as such.
Not proposing any functionality change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I should clarify that I believe we removed that parsing functionality in 9.0. I don't think the comment is relevant anymore.
Co-authored-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
No description provided.