Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trino): wrap auth strings with BasicAuthentication #9960

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Aug 29, 2024

Closes #9956.

@cpcloud cpcloud added this to the 9.4 milestone Aug 29, 2024
@cpcloud cpcloud added feature Features or general enhancements trino The Trino backend labels Aug 29, 2024
@cpcloud cpcloud requested a review from gforsyth August 29, 2024 14:39
Copy link
Member

@gforsyth gforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@gforsyth gforsyth enabled auto-merge (squash) August 29, 2024 14:44
@gforsyth
Copy link
Member

Pushed up a fix for the Trino errors about using authentication over http -- feel free to drop the commit if you want to handle it a different way

@gforsyth gforsyth disabled auto-merge August 29, 2024 16:45
@cpcloud cpcloud enabled auto-merge (squash) September 3, 2024 11:33
@cpcloud cpcloud merged commit e0f54c9 into ibis-project:main Sep 3, 2024
82 checks passed
@cpcloud cpcloud deleted the trino-basic-auth branch September 3, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features or general enhancements trino The Trino backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Trino connection issue
2 participants