fix(polars): use flatten API for ArrayFlatten implementation to avoid large string upcast
#9997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
commented
Sep 2, 2024
jcrist
approved these changes
Sep 2, 2024
cpcloud
force-pushed
the
fix-polars-flatten
branch
3 times, most recently
from
0646fc1 to
77eaba0
Compare
cpcloud
commented
Sep 3, 2024
| @@ -22,3 +25,14 @@ def test_cannot_run_sql_after_drop(con): | |||
| con.drop_table(name) | |||
| with pytest.raises(PolarsSQLInterfaceError): | |||
| con.sql(sql) | |||
|
|
|||
|
|
|||
| def test_array_flatten(con): | |||
There was a problem hiding this comment.
Moved this here in order to avoid dealing with Snowflake's PyArrow array output, which differs from other backends because of the untyped nature of its arrays.
cpcloud
force-pushed
the
fix-polars-flatten
branch
from
77eaba0 to
76d632a
Compare
cpcloud
force-pushed
the
fix-polars-flatten
branch
from
76d632a to
a5d410a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9995.