Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node 12 support #528

Closed
huineng opened this issue Apr 24, 2019 · 6 comments
Closed

node 12 support #528

huineng opened this issue Apr 24, 2019 · 6 comments

Comments

@huineng
Copy link

huineng commented Apr 24, 2019

Node 12 just got release , but ibm_db 2.5.0 got an error when installing the driver

Downloading and extraction of DB2 ODBC CLI Driver completed successfully ...
  CXX(target) Release/obj.target/odbc_bindings/src/odbc.o
Error: Command failed: node-gyp configure build  --IS_DOWNLOADED=true --IBM_DB_HOME="$IBM_DB_HOME"
In file included from ../src/odbc.cpp:28:
In file included from ../src/odbc.h:23:
In file included from ../../nan/nan.h:222:
In file included from ../../nan/nan_converters.h:67:
../../nan/nan_converters_43_inl.h:22:1: warning: 'ToBoolean' is deprecated: ToBoolean can never throw. Use Local version. [-Wdeprecated-declarations]
X(Boolean)
^
../../nan/nan_converters_43_inl.h:18:12: note: expanded from macro 'X'
      val->To ## TYPE(isolate->GetCurrentContext())                            \
           ^
<scratch space>:427:1: note: expanded from here
ToBoolean
^
/Users/guyhuinen/.node-gyp/12.0.0/include/node/v8.h:2523:3: note: 'ToBoolean' has been explicitly marked deprecated here
  V8_DEPRECATE_SOON("ToBoolean can never throw. Use Local version.",
  ^
/Users/guyhuinen/.node-gyp/12.0.0/include/node/v8config.h:322:29: note: expanded from macro 'V8_DEPRECATE_SOON'
  declarator __attribute__((deprecated(message)))
                            ^
In file included from ../src/odbc.cpp:28:
In file included from ../src/odbc.h:23:
In file included from ../../nan/nan.h:222:
In file included from ../../nan/nan_converters.h:67:
../../nan/nan_converters_43_inl.h:40:1: warning: 'BooleanValue' is deprecated: BooleanValue can never throw. Use Isolate version. [-Wdeprecated-declarations]
X(bool, Boolean)
^
../../nan/nan_converters_43_inl.h:37:15: note: expanded from macro 'X'
  return val->NAME ## Value(isolate->GetCurrentContext());   

@bimalkjha
Copy link
Member

@huineng nan need to be enhanced to support this new version of node.js. We have to wait till the next release of nan with support of node v12.x. Nan update should handle this issue. Thanks.

@huineng
Copy link
Author

huineng commented Apr 24, 2019

nodejs/nan#849

@huineng
Copy link
Author

huineng commented May 28, 2019

Can you have a look at the comments nodejs/nan#849 .The issues is closed in nan as thy have no reason to belief the latest wouldn't support node 12.

@yikuanlee
Copy link

We plan to move to node12 from 10. Any update for nan and nodejs 12 support ?

@bimalkjha
Copy link
Member

@yikuanlee We are working on it and support should be available soon. Thanks.

@bimalkjha
Copy link
Member

ibm_db@2.6.0 supports node.js v12.x. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants