Parse -Xmso from OPENJ9_JAVA_OPTIONS for main thread #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithc-ca
reviewed
Aug 14, 2023
| } | ||
| continue; /* str already incremented */ | ||
| } | ||
| str++; |
There was a problem hiding this comment.
I think this needs to be a little more sophisticated (with some of the features of parseOptionsBuffer()) to avoid mishandling quotes, etc. and values like this: -Xmso64k -Dchild.stack=-Xmso32k (the second occurrence of -Xmso should not apply).
There was a problem hiding this comment.
As discussed offline, this is better, but doesn't handle quotes (and escapes) like the VM. Quotes need not be just at the beginning and end of elements of the value (e.g. -Xmso64k -Dchild.options="-Xint -Xmso32k -Xms4M" would not be processed properly).
There was a problem hiding this comment.
I've updated it to re-use the parsing code in libjli/args.c
pshipton
force-pushed
the
mso
branch
6 times, most recently
from
b4aeaca
to
ac7cf7a
Compare
keithc-ca
requested changes
Aug 21, 2023
Issue eclipse-openj9/openj9#16105 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
|
I've made the suggested changes. |
keithc-ca
approved these changes
Aug 21, 2023
|
Jenkins compile alinux64 jdknext |
pshipton
added a commit
to pshipton/openj9-openjdk-jdk21
that referenced
this pull request
Aug 22, 2023
Issue eclipse-openj9/openj9#16105 Backport of ibmruntimes/openj9-openjdk-jdk#644 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
added a commit
to pshipton/openj9-openjdk-jdk21
that referenced
this pull request
Aug 22, 2023
Issue eclipse-openj9/openj9#16105 Backport of ibmruntimes/openj9-openjdk-jdk#644 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
added a commit
to pshipton/openj9-openjdk-jdk17
that referenced
this pull request
Aug 22, 2023
Issue eclipse-openj9/openj9#16105 Backport of ibmruntimes/openj9-openjdk-jdk#644 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
added a commit
to pshipton/openj9-openjdk-jdk11
that referenced
this pull request
Aug 22, 2023
Issue eclipse-openj9/openj9#16105 Backport of ibmruntimes/openj9-openjdk-jdk#644 Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
added a commit
to pshipton/openj9-openjdk-jdk8
that referenced
this pull request
Aug 22, 2023
Issue eclipse-openj9/openj9#16105 Backport of ibmruntimes/openj9-openjdk-jdk#644, the JLI helper functions, and parts of args.c applicable to jdk8. Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
added a commit
to pshipton/openj9-openjdk-jdk8
that referenced
this pull request
Aug 22, 2023
Issue eclipse-openj9/openj9#16105 Backport of ibmruntimes/openj9-openjdk-jdk#644, the JLI helper functions, and parts of args.c applicable to jdk8. Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
added a commit
to pshipton/openj9-openjdk-jdk8
that referenced
this pull request
Aug 24, 2023
Issue eclipse-openj9/openj9#16105 Backport of ibmruntimes/openj9-openjdk-jdk#644, the JLI helper functions, and parts of args.c applicable to jdk8. Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
added a commit
to pshipton/openj9-openjdk-jdk8
that referenced
this pull request
Aug 24, 2023
Issue eclipse-openj9/openj9#16105 Backport of ibmruntimes/openj9-openjdk-jdk#644, the JLI helper functions, and parts of args.c applicable to jdk8. Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
pshipton
added a commit
to pshipton/openj9-openjdk-jdk8
that referenced
this pull request
Aug 24, 2023
Issue eclipse-openj9/openj9#16105 Backport of ibmruntimes/openj9-openjdk-jdk#644, the JLI helper functions, and parts of args.c applicable to jdk8. Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue eclipse-openj9/openj9#16105