Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BESTEST cases according to ASHRAE 140-2020 #1750

Open
JayHuLBL opened this issue May 10, 2023 · 2 comments
Open

Update BESTEST cases according to ASHRAE 140-2020 #1750

JayHuLBL opened this issue May 10, 2023 · 2 comments
Assignees

Comments

@JayHuLBL
Copy link
Contributor

This issue is to update the BESTEST cases defined in ASHRAE 140-2020. It will include the changes that can be found from Modelica Buildings Library Issue 3005.

The new test acceptance criteria, which were published in ASHRAE 140-2020 Addendum b, will also be included in the cases.

@JayHuLBL JayHuLBL self-assigned this May 10, 2023
@JayHuLBL
Copy link
Contributor Author

@amaccarini
The ASHRAE 140-2020 has some changes different from the version 2017. Please see the documented list in Building library issue3005. In branch issue1750_updateBESTEST_models, I have updated the weather file and also updated the maximum and minimum values. However, since the test models here are lumped models, I am not sure how we can update the models accordingly.

@amaccarini
Copy link
Contributor

@JayHuLBL
Thanks for your message. I am still working on the BESTEST validation for IBPSA.ThermalZone.ISO13790 in order to update the results. I haven't had time to work on this issue yet, but I am planning to look into that during the summer. I will keep you posted!
Perhaps we could arrange a quick call to coordinate. I think I need some inputs about the python file you created for the Buildings library to automatically compare the BESTEST results. The idea is to make a similar file for the IBPSA library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants