Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ISO13790 to ReducedOrder.ISO13790 #1838

Open
mwetter opened this issue Feb 5, 2024 · 3 comments
Open

Move ISO13790 to ReducedOrder.ISO13790 #1838

mwetter opened this issue Feb 5, 2024 · 3 comments
Assignees

Comments

@mwetter
Copy link
Contributor

mwetter commented Feb 5, 2024

@amaccarini to move ISO13790 to ReducedOrder.ISO13790

@amaccarini
Copy link
Contributor

@mwetter, I think that when we discussed this issue during the meeting, we were looking into the package organization of the Buildings library, where the package ThermalZones has four sub-packages: Detailed, EnergyPlus_9_6_0, ISO13790, and ReducedOrder. With this structure, it makes sense to put ISO13790 and VDI6007 under the sub-package ReducedOrder.
However, the package ThermalZones of the IBPSA library has currently only two sub-packages: ISO13790 and ReducedOrder. Should we simply replace the name ReducedOrder with VDI6007 then? The alternative is to have ThermalZones with only one sub-package ReducedOrder and two sub-sub-packages ISO13790 and VID6007.

@mwetter
Copy link
Contributor Author

mwetter commented Feb 7, 2024

@amaccarini : We should have in the IBPSA library the structure

  ThermalZones
    ReducedOrder
       ISO13790
       VDI6007

Then, Buildings and other libraries can put their own thermal zone models into the ThermalZones package, parallel to the ReducedOrder package (or they are free to put them into other packages as appropriate).

@amaccarini
Copy link
Contributor

Sounds good. Thanks for the clarification, @mwetter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants