Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing react-router with react-router-dom #124

Closed
abhinavsau opened this issue Oct 21, 2021 · 2 comments
Closed

Replacing react-router with react-router-dom #124

abhinavsau opened this issue Oct 21, 2021 · 2 comments

Comments

@abhinavsau
Copy link
Contributor

abhinavsau commented Oct 21, 2021 •
edited
Loading

I see for this issue you removed the react-router-dom dependency. Since react-router-dom imports and re-exports all the components of react-router, isn't it better to replace react-router with react-router-dom which would give the NavLink that you needed for the test. Or is there any use case that I might be missing? Thanks @icd2k3
@icd2k3
Copy link
Owner

icd2k3 commented Oct 23, 2021

oh interesting... yea maybe we should replace it here 🤔

@abhinavsau abhinavsau mentioned this issue Oct 25, 2021
Merged
@abhinavsau
Copy link
Contributor Author

Opened a PR for you to review. Let me know if I missed anything.

@icd2k3 icd2k3 closed this as completed Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@icd2k3 @abhinavsau