Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename BackgroundGeneratorBase to BackgroundGenerator #156

Closed
martwo opened this issue Jul 3, 2023 · 0 comments
Closed

Rename BackgroundGeneratorBase to BackgroundGenerator #156

martwo opened this issue Jul 3, 2023 · 0 comments
Assignees
@martwo
Labels
code style Improvements related to code style

Comments

@martwo
Copy link
Collaborator

martwo commented Jul 3, 2023

There is no need to a *Base version of the BackgroundGenerator class. This will make the current BackgroundGenerator class obsolete.

skyllh/skyllh/core/background_generator.py

Line 16 in 16b9bf7

class BackgroundGeneratorBase(

@martwo martwo added the code style Improvements related to code style label Jul 3, 2023
@martwo martwo self-assigned this Jul 3, 2023
@martwo martwo mentioned this issue Jul 6, 2023
Merged
@martwo martwo closed this as completed in 9dfc621 Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martwo martwo

Labels
code style Improvements related to code style
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@martwo