Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Area calculation spherical space #36

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Conversation

G-Sommani
Copy link
Contributor

First part of pull request #35, as an answer to Tianlu's suggestion.

The estimation with Gauss-Green's theorem takes now into account the spherical space. The estimation by counting pixels is therefore now dropped.

Copy link
Member

@ric-evans ric-evans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try removing # flake8: noqa for at least this file? It provides a lot of useful feedback. If you do, you probably want to attempt this in #35, so you don't have to deal with a manual merge mess.

@G-Sommani
Copy link
Contributor Author

Can you try removing # flake8: noqa for at least this file? It provides a lot of useful feedback. If you do, you probably want to attempt this in #35, so you don't have to deal with a manual merge mess.

Yes, I can remove # flake8: noqa from this file. I will do it in #35 after I merge this pull request.

@G-Sommani
Copy link
Contributor Author

@ric-evans should I merge this pull request and than work on #35?

@G-Sommani G-Sommani merged commit 43ae13f into main Aug 2, 2024
14 checks passed
@G-Sommani G-Sommani deleted the area-calculation-spherical-space branch August 2, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants