Save contour files to specified output directory #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ric-evans
reviewed
Dec 12, 2024
ric-evans
reviewed
Dec 12, 2024
skyreader/plot/plot.py
Outdated
Comment on lines
838
to
842
| # Dump the whole contour | ||
| path = unique_id + ".contour.pkl" | ||
| path = self.output_dir / f"{unique_id}.contour.pkl" | ||
| print("Saving contour to", path) | ||
| with open(path, "wb") as f: | ||
| pickle.dump(saving_contours, f) |
There was a problem hiding this comment.
I recommend separating this into a separate helper function. The key indicator is that path is not used beyond this chunk. The same goes for the ascii.write() chunk above.
There was a problem hiding this comment.
Probably a good idea. I added a private method to save the contours now.
ric-evans
approved these changes
Dec 12, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.