Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate multiple crate versions #1976

Open
2 tasks done
spcan opened this issue Jul 28, 2023 · 4 comments
Open
2 tasks done

Deduplicate multiple crate versions #1976

spcan opened this issue Jul 28, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@spcan
Copy link

spcan commented Jul 28, 2023

Is there an existing issue for this?

  • I have searched the existing issues.

Is this issue related to iced?

  • My hardware is compatible and my graphics drivers are up-to-date.

What happened?

When building iced version 0.10 there are a few libraries that are imported multiple times and considerably increase the compilation time

tiny-skia

iced-tiny-skia imports tiny-skia 0.10
iced-winit imports tiny-skia 0.8.4 through winit

ttf-parser

iced-tiny-skia imports ttf-parser 0.19
iced-winit imports ttf-parser 0.17 through winit

wayland (and its subcrates)

iced-tiny-skia imports wayland 0.30 through softbuffer
iced-winit imports wayland 0.29 through window-clipboard

I just want to ask if there is a reason to use this version of the library or if some of these crates could be downgraded to a previous version to allow for a reduction in the dependencies imported, which would reduce the compilation time

What is the expected behavior?

Reduction in duplicated imported libraries

Version

crates.io release

Operating System

Linux

Do you have any log output?

None
@spcan spcan added the bug Something isn't working label Jul 28, 2023
@hecrj
Copy link
Member

hecrj commented Jul 28, 2023

It seems we are using the most recent versions. Maybe we should ask our dependencies to update theirs, instead of downgrading ours?

@Mingun
Copy link

Mingun commented Jul 28, 2023

You also can use a wider range if you don't use specific features

@hecrj
Copy link
Member

hecrj commented Jul 28, 2023

Of the dependencies mentioned here, the only direct one is tiny-skia 0.10 which we definitely need for incremental rendering and diffing.

@spcan
Copy link
Author

spcan commented Jul 28, 2023

I have been looking into the dependencies

window-clipboard has an open issue with the wayland update in which they reject the update (issue) because they want to include the functionality into winit and client-toolkit but AFAIK winit so far has rejected getting into clipboard handling, sooooo....

This seems a difficult fix, and seeing that wayland is one of the most expensive dependencies I don't see an easy fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants